Reverts most of this commit (but not all, some parts are still needed, or were reverted already in later EAs): 39c8ddcda2?style=split&whitespace=show-all&show-outdated= or 39c8ddcda2?style=split&whitespace=show-all&show-outdated=
Above commit to the audio sink was first included in EA-3835, changing the way an audio engine is auto-selected by lowest latency... but still doesn't work very well, often using cubeb when it should use SDL.
A side effect of this was that microstuttering was introduced in a few titles. In Diablo 3, the main player character appears to teleport forward a few steps, every couple of steps. It's a consistent, constant stutter when simply walking forward. Occurs for both SDL and cubeb, with cubeb noticeably worse.
3834 and 3833 didn't have this issue with SDL, and the commit above was the bulk of the changes for 3835. Reverting those changes back to the 3833 version has fixed the stutter (for me at least) in D3 as long as SDL is selected (cubeb still stutters). The only observed negative is the audio engine may need to be manually selected in global settings instead of using auto.
Also seems to have fixed intermittent microstutters in TOTK and RDR. Unaware of other titles this may fix, or possibly create a problem for (though creating issues probably is not likely.)
This will be undone (except for the analytics part) once a good reimplementation is available. I will include a configuration value for the server to use.
This commit rolls in changes required for 18.0.0 firmware from Suyus codebase plus some formatting fixes.
Co-authored-by: Exverge <exverge@exverge.xyz>
Reviewed-on: http://y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion/darktux/torzu/pulls/8
Co-authored-by: darktux <darktux@y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion>
Co-committed-by: darktux <darktux@y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion>
Commit from Suyu, looks like Yuzu devs forgot to initialize memory here.
Comment from darktux: I've changed the use of memset to std::fill.
Co-authored-by: Belal Ashraf <nullequal@noreply.localhost>
Reviewed-on: http://y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion/darktux/torzu/pulls/3
Co-authored-by: darktux <darktux@y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion>
Co-committed-by: darktux <darktux@y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion>
When compiling with -DCMAKE_BUILD_TYPE=Debug, GCC would (correctly) fail to
compile intrinsics in stb and host1x due to lack of optimizations.
Sadly, the compilation error given is bogus and Clang completing the builds
without issues does raise some eyebrows.
Therefore, force optimizations for the offending files under GCC when
creating Debug builds.
Signed-off-by: voidanix <voidanix@keyedlimepie.org>
spectranator
mateomaui
Jarrod Norwell
Reg Tiangha
lol
darktux