camerin
/
eden
mirror of https://git.eden-emu.dev/eden-emu/eden.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,733 Commits 125 Branches 23 Tags 187 MiB
Commit Graph

14736 Commits

Author SHA1 Message Date
bunnei dfacfa12d3 hle: kernel: KPriorityQueue: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 266d16c350 hle: kernel: KAffinityMask: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei ddaecce2f5 hle: kernel: GlobalSchedulerContext: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 4617be5b35 common: BitSet: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei ea30e22ef1 hle: kernel: Use C++ style comments in KScheduler, etc. 2020-12-06 00:03:24 -08:00
bunnei c3c09d9a35 kernel: KScopedSchedulerLockAndSleep: Remove unused ctor. 2020-12-06 00:03:24 -08:00
bunnei 31243d2b7a kernel: time_manager: Add missing lock guards. 2020-12-06 00:03:24 -08:00
bunnei de522657dd hle: kernel: Migrate to KScopedSchedulerLock. 2020-12-06 00:03:24 -08:00
bunnei 61e017a026 hle: kernel: Separate KScopedSchedulerLockAndSleep from k_scheduler. 2020-12-06 00:03:24 -08:00
bunnei 4f16c961c9 hle: kernel: Separate KScheduler from GlobalSchedulerContext class. 2020-12-06 00:03:24 -08:00
bunnei 039844bbb9 hle: kernel: Rewrite scheduler implementation based on Mesopshere. 2020-12-06 00:03:24 -08:00
bunnei abc079aca1 hle: kernel: physical_core: Clear exclusive state after each run. 
- This is closer to pre-multicore behavior, and works a bit better.
 2020-12-06 00:03:24 -08:00
bunnei 1ffab4019b hle: kernel: Port KAbstractSchedulerLock from Mesosphere. 2020-12-06 00:03:24 -08:00
bunnei 0c9f4d749c hle: kernel: svc: Remove reschedule on svcBreak. 
- This breaks things, and is unnecessary, since emulation will be done at this point.
 2020-12-06 00:03:24 -08:00
bunnei cd66ac3af5 hle: kernel: process: Add schedule count tracking, to be used for yield impl. 2020-12-06 00:03:24 -08:00
bunnei 5f00b01a5d hle: kernel: svc: Remove unnecessary hack in svcSleep. 2020-12-06 00:03:24 -08:00
bunnei 11e7b74858 common: Port KPriorityQueue from Mesosphere. 2020-12-06 00:03:24 -08:00
bunnei b164f6306b common: Port BitSet from Mesosphere. 2020-12-06 00:03:24 -08:00
bunnei ba09b4d69d hle: kernel: Port KAffinityMask from Mesosphere. 2020-12-06 00:03:24 -08:00
comex 20f4c9175a maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict 
On Apple platforms, FALSE and TRUE are defined as macros by
<mach/boolean.h>, which is included by various system headers.

Note that there appear to be no actual users of the names to fix up.
 2020-12-05 17:59:02 -05:00
comex 278bbcb8d7 yuzu_cmd: Remove 'users_size' 
Specifically:

    const auto size = sdl2_config->GetInteger("System", "users_size", 0);

The variable is never used, producing a warning.  I wondered if this
ought to be assigning something to in `Settings`, but nothing else in
the codebase ever mentions a setting called "users_size", so I guess
it's safe to remove...
 2020-12-05 17:50:39 -05:00
Vitor Kiguchi 31a3bf1b8c Update cubeb and request a persistent stream session 2020-12-05 22:26:41 +01:00
Lioncash 5db4785535 video_core: Resolve more variable shadowing scenarios pt.3 
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
 2020-12-05 16:02:23 -05:00
Lioncash 66bb735a95 game_list_p: Resolve deprecated usage of QVariant operator< 
This is designated as obsolete in Qt's docs (see:
https://doc.qt.io/qt-5/qvariant-obsolete.html#operator-lt)
 2020-12-05 15:38:58 -05:00
Morph 6efd390668 applets: Resolve variable shadowing 2020-12-05 08:37:13 -05:00
Lioncash 341083a5e1 video_core: Resolve more variable shadowing scenarios pt.2 
Migrates the video core code closer to enabling variable shadowing
warnings as errors.

This primarily sorts out shadowing occurrences within the Vulkan code.
 2020-12-05 06:39:35 -05:00
bunnei 32984bf3e1 Merge pull request #5124 from lioncash/video-shadow 
video_core: Resolve more variable shadowing scenarios
 2020-12-05 00:48:08 -08:00
bunnei 0c55e7820c Merge pull request #5127 from FearlessTobi/port-5617 
Port citra-emu/citra#5617: "Fix telemetry-related exit crash from use-after-free"
 2020-12-04 21:57:40 -08:00
Lioncash 50516223e3 xbyak_abi: Shorten std::size_t to size_t 
Makes for less reading.
 2020-12-05 00:43:55 -05:00
Lioncash 65a52ab81a xbyak_abi: Avoid implicit sign conversions 2020-12-05 00:43:41 -05:00
Chloe Marcec 6d887d0d92 system_version: Update to 11.0.0 2020-12-05 16:08:03 +11:00
FearlessTobi a8fce80339 Fix telemetry-related exit crash from use-after-free 
Co-Authored-By: xperia64 <xperia64@users.noreply.github.com>
 2020-12-05 02:42:50 +01:00
Lioncash 4d9a8ef8f1 codec: Remove deprecated usage of AVCodecContext::refcounted_frames 
This was only necessary for use with the
avcodec_decode_video2/avcoded_decode_audio4 APIs which are also
deprecated.

Given we use avcodec_send_packet/avcodec_receive_frame, this isn't
necessary, this is even indicated directly within the FFmpeg API changes
document here on 2017-09-26:

https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410

This prevents our code from breaking whenever we update to a newer
version of FFmpeg in the future if they ever decide to fully remove this
API member.
 2020-12-04 16:23:13 -05:00
Lioncash 2f181b6a90 video_core: Resolve more variable shadowing scenarios 
Resolves variable shadowing scenarios up to the end of the OpenGL code
to make it nicer to review. The rest will be resolved in a following
commit.
 2020-12-04 16:19:09 -05:00
Morph ce2a7beb05 nim: Stub IsLargeResourceAvailable 
- Used by Immortals Fenyx Rising
 2020-12-04 09:53:21 -05:00
bunnei 70812df905 Merge pull request #5064 from lioncash/node-shadow 
node: Eliminate variable shadowing
 2020-12-04 00:45:33 -08:00
bunnei 495f5b7583 Merge pull request #5061 from lioncash/pessimizing 
vp9/vic: Resolve pessimizing moves
 2020-12-03 23:21:12 -08:00
bunnei c1f4f013fe Merge pull request #4996 from bunnei/use-4jits 
Kernel: Refactor to use 4-instances of Dynarmic & various cleanups and improvements
 2020-12-03 15:32:45 -08:00
Lioncash 9c0408605e node: Mark member functions as [[nodiscard]] where applicable 
Prevents logic bugs from accidentally ignoring the return value.
 2020-12-03 16:03:34 -05:00
Lioncash 62d77b943a node: Eliminate variable shadowing 2020-12-03 15:59:38 -05:00
Lioncash 92a5b7b388 vp9/vic: Resolve pessimizing moves 
Removes the usage of moves that don't result in behavior different from
a copy, or otherwise would prevent copy elision from occurring.
 2020-12-03 12:33:07 -05:00
Lioncash 8e4a23e129 mouse_poller: Remove unused includes 2020-12-03 10:41:13 -05:00
Lioncash 11e20efc1d mouse_input: Invert conditional in UpdateYuzuSettings() 
Allows the struct to be constructed in place.
 2020-12-03 10:41:13 -05:00
Lioncash f8b5b65d6b mouse_input: Remove two casts and amend some formatting 
Removes the use of two static casts and improves the readability of some
vectors slightly.
 2020-12-03 10:41:09 -05:00
Lioncash 64daafbaa0 mouse_input: Resolve a -Wdocumentation warning 2020-12-03 10:26:50 -05:00
Lioncash 09b2703682 mouse_input: Remove unused includes 2020-12-03 10:26:30 -05:00
bunnei 4547af2ba5 Merge pull request #5000 from lioncash/audio-error 
audio_core: Make shadowing and unused parameters errors
 2020-12-02 23:08:43 -08:00
Lioncash 29db886722 audio_core: Make shadowing and unused parameters errors 
Moves the audio code closer to enabling warnings as errors in general.
 2020-12-03 00:54:31 -05:00
bunnei 14c58ebe23 Merge pull request #5002 from ameerj/nvdec-frameskip 
nvdec: Queue and display all decoded frames, cleanup decoders
 2020-12-02 15:55:15 -08:00
bunnei eba344f859 Merge pull request #4937 from german77/multiUDP 
InputCommon: Add multiple udp server support
 2020-12-01 11:47:37 -08:00
LC 1ec79d0982 Merge pull request #5047 from german77/MouseInput 
InputCommon: Fix implicit conversion in mouse input
 2020-12-01 09:40:46 -05:00
german 544417cd49 Fix implicit conversion in mouse input 2020-11-30 21:48:18 -06:00
bunnei ea356e8f26 Merge pull request #5013 from ReinUsesLisp/vk-early-z 
vk_shader_decompiler: Implement force early fragment tests
 2020-11-30 11:11:07 -08:00
lat9nq 400c97825e Disable web applet and warning when compiling for Linux on CI 
yuzu's web applet does not or barely reacts to user input while open in
Linux. It can be closed via 'Exit Web Applet' on the menubar, however if
yuzu is in fullscreen, this is effectively a softlock as the menubar
cannot be accessed.

This disables building yuzu with the web applet on the Linux CI target.
In addition, this disables the QMessageBox warning about not having
compiled yuzu with the web applet.
 2020-11-30 13:25:46 -05:00
bunnei 0c0c14ca1e Merge pull request #4939 from german77/MouseInput 
InputCommon: Implement full mouse support
 2020-11-29 22:59:50 -08:00
bunnei 9055027e3c Merge pull request #5005 from ReinUsesLisp/div-ceil 
common: Add Common::DivCeil and Common::DivCeilLog2
 2020-11-29 01:41:06 -08:00
bunnei 3edaafa295 kernel: scheduler: Minor cleanup to remove duplicated code. 2020-11-29 01:31:52 -08:00
bunnei 64cb411dda kernel: time_manager: Protect access with a mutex. 2020-11-29 01:31:52 -08:00
bunnei 05ff3e467e common: fiber: Use VirtualBuffer for stack memory. 
- This will be aligned by default, and helps memory usage.
 2020-11-29 01:31:52 -08:00
bunnei b2de57e93e hle: kernel: thread: Remove unused "Running" state. 2020-11-29 01:31:52 -08:00
bunnei a5b73195c9 core: arm: Implement InvalidateCacheRange for CPU cache invalidation. 2020-11-29 01:31:52 -08:00
bunnei 5114c6f3ac hle: kernel: time_manager: Avoid a crash on process exit. 2020-11-29 01:31:51 -08:00
bunnei 026a8dd832 hle: kernel: AddressArbiter: Remove unused code. 2020-11-29 01:31:51 -08:00
bunnei e7c2a66ecd hle: kernel: SynchronizationObject: Use atomic_bool for is_signaled. 2020-11-29 01:31:51 -08:00
bunnei b92d8acd2f common: fiber: Use boost::context instead of native fibers on Windows. 2020-11-29 01:31:51 -08:00
bunnei aaffe73f47 hle: kernel: multicore: Replace n-JITs impl. with 4 JITs. 2020-11-29 01:31:51 -08:00
bunnei 276a0f7b8c Merge pull request #4998 from Morph1984/bioshock-patch 
hid: Check if applet_resource exists in InitializeVibrationDevice
 2020-11-28 23:20:23 -08:00
german 2a93b187a6 Add missing types to NpadCommunicationMode 2020-11-28 21:56:02 -06:00
bunnei 4e480c2990 Merge pull request #5021 from german77/StubCommunicationMode 
HID: Stub set and get NpadCommunicationMode
 2020-11-28 15:22:46 -08:00
Chloe Marcec 35f0c8e80e audio_core: Remove temp_mix_buffer 
It's unused and doesn't need to be initialized
 2020-11-28 23:25:28 +11:00
bunnei e2b0bb1be4 Merge pull request #5015 from comex/xx-sign-compare 
tests: Fix warning about comparison between signed and unsigned
 2020-11-27 19:54:26 -08:00
bunnei 1161176ff7 Merge pull request #5011 from lioncash/file-str2 
core: Reduce string copies in GetGameFileFromPath()
 2020-11-27 17:23:00 -08:00
LC b6bb919c7b Merge pull request #5014 from comex/xx-invalid-offsetof 
CMakeLists: disable -Winvalid-offsetof
 2020-11-27 17:44:07 -05:00
comex 674da91842 CMakeLists: disable -Winvalid-offsetof 
This Clang warning complains when offsetof is used on a
non-standard-layout type (i.e. any class using various C++ features),
even though it works fine (and is not undefined behavior as of C++17).
 2020-11-27 17:42:02 -05:00
comex f2a06c61d6 tests: Fix warning about comparison between signed and unsigned 2020-11-27 17:41:20 -05:00
Lioncash c06510376a core: Eliminate remaining usages of the global system instance 
Removes all remaining usages of the global system instance. After this,
migration can begin to migrate to being constructed and managed entirely
by the various frontends.
 2020-11-27 11:40:45 -05:00
Lioncash acf893542a savedata_factory: Eliminate usage of the global system instance 
Now there's only two meaningful instances left in core.
 2020-11-27 09:45:08 -05:00
Rodrigo Locatti 69867b1690 Merge pull request #5018 from lioncash/service-global 
service: Eliminate usages of the global system instance
 2020-11-27 02:41:56 -03:00
german d9d2a0aac7 Stub set and get NpadCommunicationMode 2020-11-26 21:35:11 -06:00
Lioncash 346271b80b service: Eliminate usages of the global system instance 
Completely removes all usages of the global system instance within the
services code by passing in the using system instance to the services.
 2020-11-26 20:03:11 -05:00
comex 200a0bf755 codec: Fix `pragma GCC diagnostic pop` missing corresponding push 2020-11-26 16:35:42 -05:00
ReinUsesLisp fe1efa971f vk_shader_decompiler: Implement force early fragment tests 
Force early fragment tests when the 3D method is enabled.
The established pipeline cache takes care of recompiling if needed.

This is implemented only on Vulkan to avoid invalidating the shader
cache on OpenGL.
 2020-11-26 17:52:26 -03:00
Lioncash 064f17c5b1 core: Reduce string copies in GetGameFileFromPath() 
Eliminates some minor string churn where applicable. Also eliminates an
unnecessary vector copy.
 2020-11-26 14:05:13 -05:00
ameerj 0a89ea1ca7 Limit queue size to 10 frames 
Workaround for ZLA, which seems to decode and queue twice as many frames as it displays.
 2020-11-26 14:04:06 -05:00
bunnei a20ffebc80 Merge pull request #4975 from comex/invalid-syncpoint-id 
nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID
 2020-11-26 01:27:24 -08:00
german 56a8fee35a Implement full mouse support 2020-11-25 23:59:30 -06:00
bunnei a265c454f3 Merge pull request #4981 from ogniK5377/ioctl-ctrl 
nvservices: Reintroducee IoctlCtrl
 2020-11-25 21:48:57 -08:00
german 6708e0ec0e Add multiple udp server support 2020-11-25 23:44:41 -06:00
ameerj aa2d90b35c Address PR feedback 
remove some redundant moves, make deleter match naming guidelines.

Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>
 2020-11-26 00:18:26 -05:00
ReinUsesLisp 2600f1353d common: Add Common::DivCeil and Common::DivCeilLog2 
Add an equivalent to 'Common::AlignUp(n, d) / d' and a log2 alternative.
 2020-11-25 23:37:56 -03:00
Jan Beich 805312e278 input_common: ignore some Clang warnings after c8aec32f12 
error: unknown warning option '-Werror=unused-but-set-parameter'; did you mean '-Werror=unused-parameter'? [-Werror,-Wunknown-warning-option]
error: unknown warning option '-Werror=unused-but-set-variable'; did you mean '-Werror=unused-const-variable'? [-Werror,-Wunknown-warning-option]
 2020-11-25 23:57:11 +00:00
Rodrigo Locatti d9c847bdde Merge pull request #4976 from comex/poll-events 
Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread
 2020-11-25 20:44:53 -03:00
ameerj 5beb990349 Queue decoded frames, cleanup decoders 2020-11-25 17:10:44 -05:00
Rodrigo Locatti a5029e54b0 Merge pull request #4946 from ameerj/alpha-test 
renderer_vulkan: Implement alpha testing
 2020-11-25 18:48:34 -03:00
ameerj 942dff1fd8 cleanup unneeded comments and newlines 2020-11-25 14:46:08 -05:00
bunnei 93d511896d Merge pull request #4959 from Morph1984/emulated-controller-styleset 
configure_input_player: Use the NpadStyleSet to limit the available controllers shown
 2020-11-25 11:20:46 -08:00
bunnei 5584c7e5e5 Merge pull request #4932 from ogniK5377/misc-audio 
audren: Make use of nodiscard, rework downmixing, release all buffers
 2020-11-25 10:50:52 -08:00
Morph 9b00708d96 hid: Check if applet_resource exists in InitializeVibrationDevice 2020-11-25 13:33:30 -05:00
bunnei bd0a2db49a Merge pull request #4978 from bunnei/shutdown-crash 
core: cpu_manager: Fix shutdown crash when closing before emulation starts.
 2020-11-25 01:20:01 -08:00
ameerj a981e7d69c Refactor MaxwellToSpirvComparison. Use Common::BitCast 
Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>
 2020-11-25 00:33:20 -05:00
ameerj 7d48b8be54 Address PR feedback from Rein 2020-11-24 22:46:45 -05:00
ameerj 47f8e43c22 vulkan_renderer: Alpha Test Culling Implementation 
Used by various textures in many titles, e.g.  SSBU menu.
 2020-11-24 22:46:45 -05:00
bunnei e4938afd40 Merge pull request #4905 from german77/AnalogFromButton 
Allow to dial any angle with digital joystick
 2020-11-24 16:04:55 -08:00
bunnei 28843b094f core: cpu_manager: Fix shutdown crash when closing before emulation starts. 2020-11-24 15:25:39 -08:00
bunnei 173d78f71e frontend: yuzu (qt): Register a callback for ExecuteProgram. 2020-11-24 15:18:29 -08:00
bunnei faffc3144c service: am: Implement ExecuteProgram and required stubs. 
- This is used by Super Mario 3D All-Stars.
 2020-11-24 15:17:43 -08:00
bunnei 9f8d7748d9 core: loader: Implement support for loading indexed programs. 2020-11-24 15:16:24 -08:00
bunnei 5f53d285aa hle: services: Fix a crash with improper NVFlinger lifetime management. (#4977) 
* hle: services: Fix a crash with improper NVFlinger lifetime management.

- This crash would happen when attempting to shutdown yuzu early on in boot.
 2020-11-24 14:31:58 -08:00
comex 00f2c7fbb9 nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID 
- Use .at() instead of raw indexing when dealing with untrusted indices.

- For the special case of WaitFence with syncpoint id UINT32_MAX,
  instead of crashing, log an error and ignore.  This is what I get when
  running Super Mario Maker 2.
 2020-11-24 12:59:41 -05:00
Rodrigo Locatti 8fd45a009a Merge pull request #3681 from lioncash/component 
decoder/image: Fix incorrect G24R8 component sizes in GetComponentSize()
 2020-11-24 04:38:03 -03:00
Rodrigo Locatti 4f1f4ecef7 Merge pull request #4942 from lioncash/system 
core: Make use of [[nodiscard]] with the System class
 2020-11-24 04:26:59 -03:00
Rodrigo Locatti 2717355678 Merge pull request #4972 from lioncash/unused4 
svc: Remove unnecessary [[maybe_unused]] tag
 2020-11-24 04:25:59 -03:00
bunnei f2bb584578 input_common: Fix typo in gc_poller.cpp with [[maybe_unused]]. 2020-11-23 21:42:06 -08:00
Chloe Marcec f8d84ecae2 nvservices: Reintroducee IoctlCtrl 
Fixes regression caused by #4907 which caused games like Breath of the Wild 1.0.0 not to boot.
 2020-11-24 16:40:23 +11:00
bunnei 2382020d8d input_common: Add more missing [[maybe_unused]] from #4927. 2020-11-23 20:50:35 -08:00
bunnei 2ac1148798 Fix warnings in core/frontend/input.h with [[maybe_unused]] 
Fixes build break due to #4927
 2020-11-23 18:11:21 -08:00
bunnei ec40411cfe Merge pull request #4927 from lioncash/input-error 
input_common: Treat warnings as errors
 2020-11-23 17:25:53 -08:00
comex bb729eefce Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread 
EmuWindow::PollEvents was called from the GPU thread (or the CPU thread
in sync-GPU mode) when swapping buffers.  It had three implementations:

- In GRenderWindow, it didn't actually poll events, just set a flag and
  emit a signal to indicate that a frame was displayed.

- In EmuWindow_SDL2_Hide, it did nothing.

- In EmuWindow_SDL2, it did call SDL_PollEvents, but this is wrong
  because SDL_PollEvents is supposed to be called on the thread that set
  up video - in this case, the main thread, which was sleeping in a
  busyloop (regardless of whether sync-GPU was enabled).  On macOS this
  causes a crash.

To fix this:

- Rename EmuWindow::PollEvents to OnFrameDisplayed, and give it a
  default implementation that does nothing.

- In EmuWindow_SDL2, do not override OnFrameDisplayed, but instead have
  the main thread call SDL_WaitEvent in a loop.
 2020-11-23 17:58:49 -05:00
bunnei 7781ef2038 Merge pull request #4451 from slashiee/extended-logging 
logging/settings: Increase maximum log size to 100 MB and add extended logging option
 2020-11-23 13:34:15 -08:00
Lioncash b038dcf23c svc: Remove unnecessary [[maybe_unused]] tag 
The parameter is used in this function, so this suppression isn't
necessary.
 2020-11-23 10:17:20 -05:00
Lioncash c8aec32f12 input_common: Treat warnings as errors 
Migrates over warnings as errors for input common to match how the
common library treats warnings as errors.
 2020-11-22 04:50:03 -05:00
bunnei c0ca8b9fa4 Merge pull request #4944 from lioncash/system-rem 
patch_manager: Remove usages of the global system instance
 2020-11-21 22:12:34 -08:00
Morph e718f63b22 Merge pull request #4954 from lioncash/compare 
gl_rasterizer: Make floating-point literal a float
 2020-11-22 09:55:23 +08:00
bunnei 9ccd07c0ea Merge pull request #4955 from lioncash/move3 
async_shaders: std::move data within QueueVulkanShader()
 2020-11-21 01:21:08 -08:00
bunnei 7e733589be Merge pull request #4907 from ogniK5377/nvdrv-cleanup 
core: Make nvservices more standardized
 2020-11-20 22:15:44 -08:00
Morph 75aa6e9beb applets/controller: Use a pair of emulated controller index to controller type 2020-11-20 22:22:22 -05:00
Morph a8ba5c5929 configure_input_player: Use the npad style set to show the available controllers 
This will reduce the likelihood of an invalid controller type to be set within a game
 2020-11-20 22:22:22 -05:00
LC b0e014d8c8 Merge pull request #4957 from ReinUsesLisp/alpha-test-rt 
gl_rasterizer: Remove warning of untested alpha test
 2020-11-20 21:19:06 -05:00
ReinUsesLisp 6263722e4d gl_rasterizer: Remove warning of untested alpha test 
Alpha test has been proven to only affect the first render target.
 2020-11-20 23:17:40 -03:00
bunnei bba996075e Merge pull request #4953 from lioncash/shader-shadow 
shader_bytecode: Eliminate variable shadowing
 2020-11-20 16:58:14 -08:00
bunnei ac9e9991e6 Merge pull request #4951 from bunnei/olsc-stub 
hle: service: Stub OLSC Initialize and SetSaveDataBackupSettingEnabled functions.
 2020-11-20 14:06:37 -08:00
bunnei 2f0eb8d38c olsc: Move member initialization to after member functions. 2020-11-20 10:50:50 -08:00
Lioncash 953aff6f0e async_shaders: emplace threads into the worker thread vector 
Same behavior, but constructs the threads in place instead of moving
them.
 2020-11-20 04:46:56 -05:00
Lioncash a15dc601be async_shaders: Simplify implementation of GetCompletedWork() 
This is equivalent to moving all the contents and then clearing the
vector. This avoids a redundant allocation.
 2020-11-20 04:44:44 -05:00
Lioncash 088767da00 async_shaders: Simplify moving data into the pending queue 2020-11-20 04:41:29 -05:00
Lioncash 8ac9c08758 async_shaders: std::move data within QueueVulkanShader() 
Same behavior, but avoids redundant copies.

While we're at it, we can simplify the pushing of the parameters into
the pending queue.
 2020-11-20 04:38:18 -05:00
Lioncash ae52755d5c gl_rasterizer: Make floating-point literal a float 
Gets rid of an unnecessary expansion from float to double.
 2020-11-20 04:24:33 -05:00
Lioncash b482ef0f06 shader_bytecode: Make use of [[nodiscard]] where applicable 
Ensures that all queried values are made use of.
 2020-11-20 02:20:37 -05:00
Lioncash b0172c1888 shader_bytecode: Eliminate variable shadowing 2020-11-20 02:13:45 -05:00
Morph c10e0127cc Merge pull request #4941 from lioncash/config 
configure_input_player: Use static qualifier for IsProfileNameValid()
 2020-11-20 14:16:01 +08:00
LC 1368dff078 Merge pull request #4950 from german77/RumbleStrenght 
Modify rumble amplification
 2020-11-20 00:40:09 -05:00
LC 4b633461f1 Merge pull request #4952 from ReinUsesLisp/bit-cast 
common/bit_cast: Add function matching std::bit_cast without constexpr
 2020-11-20 00:39:30 -05:00
Rodrigo Locatti 4263ecebf5 Merge pull request #4308 from ReinUsesLisp/maxwell-3d-funcs 
maxwell_3d: Move code to separate functions and insert instead of push_back
 2020-11-20 01:57:22 -03:00
ReinUsesLisp 778c06d35b common/bit_cast: Add function matching std::bit_cast without constexpr 
Add a std::bit_cast-like function archiving the same runtime results as
the standard function, without compile time support.

This allows us to use bit_cast while we wait for compiler support, it
can be trivially replaced in the future.
 2020-11-20 01:52:37 -03:00
bunnei 655892e84b hle: service: Stub OLSC Initialize and SetSaveDataBackupSettingEnabled functions. 
- Used by Animal Cross: New Horizons v1.6.0 update, minimal stub gets this update working.
 2020-11-19 12:36:09 -08:00
german77 3edd74463f Modify rumble amplification 2020-11-19 11:30:52 -06:00
Lioncash 638f982efc virtual_buffer: Do nothing on resize() calls with same sizes 
Prevents us from churning memory by freeing and reallocating a memory
block that would have already been adequate as is.
 2020-11-19 07:54:03 -05:00
bunnei d2aae53f23 Merge pull request #4936 from lioncash/page 
page_table: Allow page tables to be moved
 2020-11-18 20:40:10 -08:00
Lioncash b4b63c878f patch_manager: Remove usages of the global system instance 
With this, only 19 usages of the global system instance remain within
the core library.

We're almost there.
 2020-11-18 09:36:48 -05:00
Lioncash 82ef99b107 core: Remove unused private Init function for the System class 
This isn't used, so it can be removed.
 2020-11-18 02:09:08 -05:00
Lioncash 637aa4ddef core: Make use of [[nodiscard]] with the System class 
Given this is a central class, we should flag cases where the return
value of some functions not being used is likely a bug.
 2020-11-18 02:06:44 -05:00
Lioncash 8e015472a3 configure_input_player: Use static qualifier for IsProfileNameValid() 
This is a static member function, so we don't need use an existing
instance to call this function.
 2020-11-17 23:12:44 -05:00
bunnei afa4ced6e4 Merge pull request #4866 from Morph1984/mjolnir-p3-prod 
Project Mjölnir: Part 3 - Controller Profiles and Vibration Rework
 2020-11-17 20:02:27 -08:00
Lioncash d02005bbe9 virtual_buffer: Add compile-time type-safety guarantees with VirtualBuffer 
VirtualBuffer makes use of VirtualAlloc (on Windows) and mmap() (on
other platforms). Neither of these ensure that non-trivial objects are
properly constructed in the allocated memory.

To prevent potential undefined behavior occurring due to that, we can
add a static assert to loudly complain about cases where that is done.
 2020-11-17 20:09:58 -05:00
Lioncash b9b02276eb page_table: Allow page tables to be moved 
Makes page tables and virtual buffers able to be moved, but not copied,
making the interface more flexible.

Previously, with the destructor specified, but no move assignment or
constructor specified, they wouldn't be implicitly generated.
 2020-11-17 20:08:20 -05:00
Lioncash 60b72b1deb page_table: Add missing doxygen parameters to Resize() 
Resolves two -Wdocumentation warnings.
 2020-11-17 19:45:20 -05:00
Lioncash 81f7292269 page_table: Remove unnecessary header inclusions 
Prevents indirect inclusions for these headers.
 2020-11-17 19:43:27 -05:00
Lioncash e71d8eef5e rasterizer_interface: Make use of [[nodiscard]] where applicable 2020-11-17 07:19:13 -05:00
Lioncash 049b4d4427 render_base: Make use of [[nodiscard]] where applicable 2020-11-17 07:19:12 -05:00
Lioncash 47bc37f5cf gpu: Make use of [[nodiscard]] where applicable 2020-11-17 07:19:09 -05:00
bunnei f4e1b9076c Merge pull request #4929 from lioncash/nodiscard-input 
motion_input: Mark member functions as [[nodiscard]] where applicable
 2020-11-16 21:40:16 -08:00
Chloe Marcec 808da92335 Addressed changes 2020-11-17 15:40:19 +11:00
Chloe Marcec a894cf5169 audren: Make use of nodiscard, rework downmixing, release all buffers 
Preliminary work for upmixing & general cleanup. Fixes basic issues in games such as Shovel Knight and slightly improves the LEGO games. Upmixing stitll needs to be implemented.

Audio levels in a few games will be fixed as we now use the downmix coefficients when possible instead of supplying our own
 2020-11-17 14:14:29 +11:00
Morph f5ee5e7f3c sdl_impl: Pump SDL Events at 1000 Hz 2020-11-15 23:33:21 -05:00
Morph 7af3c351ac configure_input: Accommodate for the mouse input device engine 2020-11-15 23:33:21 -05:00
Morph 2d3476dd7f hid: Reimplement Begin/EndPermitVibrationSession 
Upon further investigation, these commands allow temporary vibrations even when the "Controller Vibration" system setting is disabled. As a result, vibrations are allowed when either the system setting or this flag is set to true. Therefore, we can only block vibrations when both flags are set to false.
 2020-11-15 23:33:21 -05:00
Morph 7adf26daf0 controllers/npad: Load input devices on init 2020-11-15 23:33:21 -05:00
Morph 23cc14cd09 configure_input: Update the input profiles for other player tabs 2020-11-15 23:33:21 -05:00
Morph 75ee0c94a0 general: Fix compiler warnings on linux and miscellaneous changes 2020-11-15 23:33:21 -05:00
Morph 24cfdbc7fe sdl_impl: Revert to the "old" method of mapping sticks 
Not all controllers have a SDL_GameController binding. This caused controllers not present in the SDL GameController database to have buttons mapped instead of axes.

Furthermore, it was not possible to invert the axes when it could be useful such as emulating a horizontal single joycon or other potential cases. This allows us to invert the axes by reversing the order of mapping (vertical, then horizontal).
 2020-11-15 23:33:21 -05:00
Morph f80127d4e0 applets/controller: Change the input button to create input profiles 
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-11-15 23:33:21 -05:00
Morph bd42b2093c controllers/npad: Remove the old vibration filter 
Previously we used a vibration filter that filters out amplitudes close to each other. It turns out there are cases where this results into vibrations that are too inaccurate. Remove this and move the 100Hz vibration filter (Only allowing a maximum of 100 vibrations per second) from sdl_impl to npad when enable_accurate_vibrations is set to false.
 2020-11-15 23:33:21 -05:00
Morph ad45ceeaf0 input: Disconnect a controller prior to connecting a new one 
Some games do not respond to a change in controller type if 1) The controller is not disconnected prior to being reconnected and/or 2) The controller is reconnected instantly after being disconnected.

Since it is not possible to change controllers instantly on hardware and requiring a disconnect prior to connecting a new one, we should emulate this as well with a small delay, fixing the aforementioned issue.
 2020-11-15 23:33:21 -05:00
Morph 6f80c78568 hid: Implement InitializeVibrationDevice and IsVibrationDeviceMounted 2020-11-15 23:33:20 -05:00
Morph ad3905fe27 input_common: Add VibrationDevice and VibrationDeviceFactory 
A vibration device is an input device that returns an unsigned byte as status.
It represents whether the vibration device supports vibration or not.
If the status returns 1, it supports vibration. Otherwise, it does not support vibration.
 2020-11-15 23:33:20 -05:00
Morph cce389221b configure_input: Add per-player vibration 
Allows for enabling and modifying vibration and vibration strength per player.
Also adds a toggle for enabling/disabling accurate vibrations.

Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-11-15 23:33:20 -05:00
Morph ee8ec56291 settings: Remove global vibration strength modifier 
This will be replaced in favor of per-player vibration strength modifiers.
 2020-11-15 23:33:20 -05:00
Morph bb0a55c4db hid: Mark Begin/EndPermitVibrationSession as stubs 
The implementation of these commands seem incomplete and causes rumble in Super Mario Party to stop working since only EndPermitVibrationSession is called. Thus, these are better off being marked as a stub until this can be investigated more thoroughly.
 2020-11-15 23:33:20 -05:00
Morph cd2f8d7e4a controllers/npad: Send an empty vibration on destruction/deactivation 
This stops all controllers from continuously vibrating when emulation is stopped.
 2020-11-15 23:33:20 -05:00
Morph 193418c57f hid: Stub IsVibrationDeviceMounted 
- Used in Super Mario Odyssey
 2020-11-15 23:33:20 -05:00
Morph ed9df522ec controllers/npad: Add heuristics to reduce rumble state changes 
Sending too many state changes in a short period of time can cause massive performance issues.
As a result, we have to use several heuristics to reduce the number of state changes to minimize/eliminate this performance impact while maintaining the quality of these vibrations as much as possible.
 2020-11-15 23:33:20 -05:00
Morph 06bc7678ba configure_input: Hook up the vibration percentage spinbox 
This allows setting the vibration strength percentage anywhere from 1% to 100%.
Also hooks up the remaining motion button and checkbox in the Controller Applet.
 2020-11-15 23:33:20 -05:00
Morph 3281c3b1cb controllers/npad: Stop games from vibrating incorrect controllers 
Fixes vibration in 1-2 Switch and potentially other games where they would vibrate both players' joycons at the same time.
 2020-11-15 23:33:20 -05:00
Morph f474cab023 hid: Fix controller rumble based on new research 
This fixes the issue where rumble is only sent to the first controller.
Now, individual controllers can receive their own rumble commands.
 2020-11-15 23:33:20 -05:00
Morph 82d901ae8b hid: Pop a struct of parameters instead of popping individual parameters 
Some parameters need to be doubleword aligned due to the presence of the applet_resource_user_id.
Previously, this value was invalid in many commands where it was not doubleword aligned when popped.
 2020-11-15 23:33:20 -05:00
Morph dc7a9a7be2 hid: Reorder all HID commands 
Reorders all HID commands in command id order.
 2020-11-15 23:33:20 -05:00
Morph c9937559f4 hid: Implement GetVibrationDeviceInfo 
The first u32 describes the vibration device type which is a Linear Resonant Actuator used in Nintendo Switch controller hardware.

The second u32 describes the vibration device position, in this case distinguishing between left and right vibration actuators.

Pro Controllers have 2 LRAs each that can vibrate independently of each other, which means they have 2 distinct vibration device handles to distinguish between the two actuators.

Similarly for joycons, the left joycon can be distinguished from the right joycon through the vibration device handle since each joycon has 1 LRA.
 2020-11-15 23:33:20 -05:00
Morph 8a35dd51ee hid: Stub InitializeVibrationDevice 2020-11-15 23:33:20 -05:00
Morph 294f3dd914 controllers/npad: Rename NPadType to NpadStyleSet 
This more accurately represents the underlying type and avoids confusion with NpadType
 2020-11-15 23:33:20 -05:00
Morph f279871f0b controllers/npad: Add DeviceHandle struct 
A DeviceHandle describes a vibration device or six-axis sensor based on the npad type, npad id, and device index/position
 2020-11-15 23:33:20 -05:00
Morph b29a52982a configure_input_player: Change "Defaults" button behavior 
RestoreDefaults() now restores the selected devices' mappings using UpdateMappingWithDefaults().
This allows us to move the keyboard mapping from RestoreDefaults() to UpdateMappingWithDefaults().
 2020-11-15 23:33:20 -05:00
Morph 1c1a83a20d settings: Preparation for per-game input settings 2020-11-15 23:33:20 -05:00
Morph 5eb160d4c6 udp/client: Reduce testing period to 5 seconds 2020-11-15 23:33:19 -05:00
Morph 82d18bcf61 config: Migrate config files into config/custom 
Co-authored-by: lat9nq <lat9nq@virginia.edu>
 2020-11-15 23:33:19 -05:00
Morph 0a85f0fd25 controllers/npad: Connect a controller on init if none are connected 2020-11-15 23:33:19 -05:00
Morph a7dd4f21dd applets/controller: Auto accept a valid single player configuration 2020-11-15 23:33:19 -05:00
Morph d1d564db07 bootmanager: Allow mouse clicks only if touch is disabled 
Previously mouse clicks will not register when touch is disabled.
This rectifies that and allows mouse clicks to be mapped to other buttons if the touchscreen is disabled.
 2020-11-15 23:33:19 -05:00
Morph c3a9d5de40 input_profiles: Implement input profiles 2020-11-15 23:33:19 -05:00
Morph ad9a909bc7 configure_input_player: Implement input exclusivity and persistence 
With this, the "Input Devices" combobox should accurately reflect the input device being used and disallows inputs from other input devices unless the input device is set to "Any".
 2020-11-15 23:33:19 -05:00
Morph 4999d2443d ui/themes: Cleanup UI 2020-11-15 23:33:19 -05:00