204ed73e8c
loader: Remove unnecessary constructor call in IdentifyFile()
...
RealVfsFile inherits from VfsFile, the instance from std::make_shared is
already compatible with the function argument type, making the copy
constructor call unnecessary.
2018-07-23 17:44:58 -04:00
d5a96f2c94
linker: Remove unused parameter from WriteRelocations()
...
is_jump_relocation is never used within the function, so we can just
remove it.
2018-07-23 17:40:12 -04:00
3a72ee5fec
nro: Replace inclusion with a forward declaration
...
It's sufficient to use a forward declaration instead of a direct
inclusion here.
2018-07-23 17:29:02 -04:00
a2c69eb949
nro: Make bracing consistent
...
Makes the code more uniform, and also braces cases where the body of an
unbraced conditional travels more than one line.
2018-07-23 17:24:29 -04:00
6fd1615b93
nro: Make constructor explicit
...
Makes it consistent with the other Apploader constructors, and prevents
implicit conversions.
2018-07-23 17:20:33 -04:00
df82410454
nro: Remove unused forward declaration
...
This isn't used anywhere in the header.
2018-07-23 17:19:42 -04:00
ac0c52dd5f
NRO Assets and NACP file format
...
Cleanup
Review fixes
2018-07-23 12:34:26 -04:00
861405d6c0
file_util, vfs: Use std::string_view where applicable
...
Avoids unnecessary construction of std::string instances where
applicable.
2018-07-22 03:22:21 -04:00
574be087d4
file_util: Use a u64 to represent number of entries
...
This avoids a truncating cast on size. I doubt we'd ever traverse a
directory this large, however we also shouldn't truncate sizes away.
2018-07-21 22:42:08 -04:00
bd9786a6ff
Merge pull request #752 from Subv/vfs_load
...
Loader: Only print the module names and addresses if they actually exist.
2018-07-20 22:57:18 -07:00
c1cc141fb0
Loader: Only print the module names and addresses if they actually exist.
2018-07-20 19:59:15 -05:00
083b638e85
Merge pull request #737 from lioncash/move
...
filesys/loader: std::move VirtualFile instances in constructors where applicable
2018-07-20 09:21:15 -07:00
c9b1340d3d
loader/{nca, nro}: std::move VirtualFile in the constructors where applicable
...
This avoids unnecessary atomic reference count increments and decrements
2018-07-20 00:10:24 -04:00
3bc310cb92
nso: Silence implicit sign conversion warnings
2018-07-19 20:51:15 -04:00
d0dd836d53
nso: Remove unused function ReadSegment()
2018-07-19 20:49:27 -04:00
fdf72b6b60
Merge pull request #719 from lioncash/docs
...
loader: Amend Doxygen comments
2018-07-19 16:11:09 -07:00
b4e1375e78
Merge pull request #718 from lioncash/read
...
loader/nso: Check if read succeeded in IdentifyFile() before checking magic value
2018-07-19 16:10:29 -07:00
ebefc0f080
loader: Amend Doxygen comments
...
These weren't adjusted when VFS was introduced
2018-07-19 14:04:33 -04:00
71dc75b71e
loader/nso: Check if read succeeded in IdentifyFile() before checking magic value
...
We should always assume the filesystem is volatile and check each IO
operation. While we're at it reorganize checks so that early-out errors
are near one another.
2018-07-19 12:43:21 -04:00
d0f53d27e0
loader/nro: Resolve sign mismatch warnings
2018-07-18 22:27:22 -04:00
b20bac710d
loader/nso: Remove unnecessary vector resizes
...
We can just initialize these vectors directly via their constructor.
2018-07-18 22:26:41 -04:00
0a48b45954
loader/nso: Resolve sign mismatch warnings
2018-07-18 22:26:37 -04:00
82150bd5c1
Virtual Filesystem 2: Electric Boogaloo ( #676 )
...
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
2018-07-18 18:07:11 -07:00
753d85fb0c
General Filesystem and Save Data Fixes ( #670 )
2018-07-17 12:42:15 -07:00
d8d8be6ac0
More improvements to GDBStub ( #653 )
...
* More improvements to GDBStub
- Debugging of threads should work correctly with source and assembly level stepping and modifying registers and memory, meaning threads and callstacks are fully clickable in VS.
- List of modules is available to the client, with assumption that .nro and .nso are backed up by an .elf with symbols, while deconstructed ROMs keep N names.
- Initial support for floating point registers.
* Tidy up as requested in PR feedback
* Tidy up as requested in PR feedback
2018-07-12 20:22:59 -07:00
0c22a8d514
Revert "Virtual Filesystem ( #597 )"
...
This reverts commit 12e9522b32
2018-07-07 20:24:51 -07:00
12e9522b32
Virtual Filesystem ( #597 )
...
* Add VfsFile and VfsDirectory classes
* Finish abstract Vfs classes
* Implement RealVfsFile (computer fs backend)
* Finish RealVfsFile and RealVfsDirectory
* Finished OffsetVfsFile
* More changes
* Fix import paths
* Major refactor
* Remove double const
* Use experimental/filesystem or filesystem depending on compiler
* Port partition_filesystem
* More changes
* More Overhaul
* FSP_SRV fixes
* Fixes and testing
* Try to get filesystem to compile
* Filesystem on linux
* Remove std::filesystem and document/test
* Compile fixes
* Missing include
* Bug fixes
* Fixes
* Rename v_file and v_dir
* clang-format fix
* Rename NGLOG_* to LOG_*
* Most review changes
* Fix TODO
* Guess 'main' to be Directory by filename
2018-07-06 10:51:32 -04:00
d74d2a77cb
Update clang format
2018-07-02 21:45:47 -04:00
e159c550d8
Rename logging macro back to LOG_*
2018-07-02 21:45:47 -04:00
a47f36da7b
Add support for decrypted NCA files ( #567 )
...
* Start to add NCA support in loader
* More nca stuff
* More changes to nca.cpp
* Now identifies decrypted NCA cont.
* Game list fixes and more structs and stuff
* More updates to Nca class
* Now reads ExeFs (i think)
* ACTUALLY LOADS EXEFS!
* RomFS loads and games execute
* Cleanup and Finalize
* plumbing, cleanup and testing
* fix some things that i didnt think of before
* Preliminary Review Changes
* Review changes for bunnei and subv
2018-06-21 11:16:23 -04:00
1b310cbb3a
general: Make formatting of logged hex values more straightforward
...
This makes the formatting expectations more obvious (e.g. any zero padding specified
is padding that's entirely dedicated to the value being printed, not any pretty-printing
that also gets tacked on).
2018-05-02 09:49:36 -04:00
324ee31fc3
general: Convert assertion macros over to be fmt-compatible
2018-04-27 10:04:02 -04:00
ff63e4d3fc
loader: Move old logging macros over to new fmt-capable ones
2018-04-24 20:22:32 -04:00
4be07d1090
Kernel: Use 0x2C as default main thread priority for homebrew and lone NRO/NSOs
2018-04-20 21:04:35 -05:00
6d5b25c136
core, main.h: Abort on 32Bit ROMs ( #309 )
...
* core, main.h: Abort on 32Bit ROMs
* main.cpp: Fix Grammar
2018-04-06 11:06:32 -04:00
ba7cd88412
deconstructed_rom_directory.cpp: Fix Typo
2018-04-03 00:20:35 +02:00
36cdd5a39c
memory: Fix stack region.
2018-03-31 16:06:45 -04:00
1212e9e231
Clean Warnings (?)
2018-03-19 17:07:08 +01:00
a26561ce20
kernel: Move stack region outside of application heap.
2018-03-16 18:32:23 -04:00
f16763ed52
core: Move process creation out of global state.
2018-03-14 18:42:19 -04:00
a9c51be95e
Kernel: Store the program id in the Process class instead of the CodeSet class.
...
There may be many CodeSets per Process, so it's wasteful and overcomplicated to store the program id in each of them.
2018-03-01 19:03:53 -05:00
d5e38de1ec
loader: Check error on NPDM load, use TID for CodeSet
2018-02-25 07:41:36 -07:00
013d8828a3
loader: Use NPDM information when loading NSOs
2018-02-25 07:02:47 -07:00
0dc7699bf2
nso: Silence formatting specifier warnings
2018-02-14 01:52:55 -05:00
bf863bdb34
deconstructed_rom_directory: Silence formatting specifier warnings
2018-02-14 01:52:55 -05:00
a6eb36e548
Changed .istorage to .romfs
2018-02-05 00:01:10 -08:00
985c960e85
deconstructed_rom_directory: Implement istorage loading for RomFS.
2018-01-21 15:39:31 -05:00
f1f6d730a5
Merge pull request #92 from gdkchan/nro_refactor
...
Fix NRO entry point
2018-01-20 23:10:15 -05:00
76b2dabd35
loader: Minor style fix in deconstructed_rom_directory
2018-01-20 20:13:53 -06:00
ca0fb0079c
Merge pull request #117 from jroweboy/clang-format
...
Clang format as a build target
2018-01-20 19:12:21 -05:00
ea88c44eb8
Format: Run the new clang format on everything
2018-01-20 16:45:11 -07:00
9b7e8a2e2b
loader: Clean up ctors and includes.
2018-01-20 15:54:17 -05:00
b870202ad5
loader: Add DeconstructedRomDirectory for game dumps.
2018-01-20 15:54:15 -05:00
f2d6ec1404
loader: Refactor to also pass filepath into IdentifyType.
2018-01-20 14:59:44 -05:00
965c2bddb2
nso: Remove code specific to directory loading.
2018-01-20 14:59:42 -05:00
bb3209e8f1
Fix NRO Entry Point
2018-01-18 17:18:43 -03:00
89f7882ab4
Fix NRO loading
2018-01-17 20:16:09 -03:00
1402e97994
Remove relocation on NSO/NRO
2018-01-17 17:01:10 -03:00
64eccfb72b
Merge pull request #44 from Rozelette/master
...
nso: Modify .bss size calculation logic
2018-01-16 17:24:49 -05:00
41bfd994f6
clang-format
2018-01-16 18:05:21 +00:00
2e5806922f
nso: Modify .bss size calculation logic
2018-01-16 11:14:36 -06:00
7fe337b38d
nso: Load subsdk4 if available.
2018-01-15 17:18:24 -05:00
84ad54795f
Add missing FileType declarations in GuessFromExtension and GetFileTypeString
2018-01-14 19:00:16 +01:00
182548ec86
yuzu: Update license text to be consistent across project.
2018-01-13 16:22:39 -05:00
02dba7283f
nso: Always load the filepath specified by the user.
2018-01-07 12:44:36 -05:00
0fba69c235
nso: Load more common submodules.
2017-10-22 23:50:26 -04:00
ec6eb66383
memory: Support 32-bit paging, move heap address space up.
2017-10-22 23:17:59 -04:00
5e11c12766
core: Refactor MakeMagic usage and remove dead code.
2017-10-15 00:11:38 -04:00
14ebd959bd
nso: Add a log for loading submodules.
2017-10-14 17:37:51 -04:00
e36d959e34
Remove more 3DS-specific code.
2017-10-12 21:29:53 -04:00
5993f6f6de
Remove lots more 3DS-specific code.
2017-10-12 21:21:49 -04:00
775cf60729
Merge remote-tracking branch 'upstream/master' into nx
...
# Conflicts:
# src/core/CMakeLists.txt
# src/core/arm/dynarmic/arm_dynarmic.cpp
# src/core/arm/dyncom/arm_dyncom.cpp
# src/core/hle/kernel/process.cpp
# src/core/hle/kernel/thread.cpp
# src/core/hle/kernel/thread.h
# src/core/hle/kernel/vm_manager.cpp
# src/core/loader/3dsx.cpp
# src/core/loader/elf.cpp
# src/core/loader/ncch.cpp
# src/core/memory.cpp
# src/core/memory.h
# src/core/memory_setup.h
2017-10-09 23:56:20 -04:00
e36ccd5ff1
loader: Various improvements for NSO/NRO loaders.
2017-10-09 21:39:32 -04:00
90cc352a37
loader: Add support for NRO, as well as various fixes and shared linker.
2017-10-05 23:30:08 -04:00
f44ce614ef
nso: Fixes to support homebrew NSOs without a MOD header.
2017-10-03 18:30:02 -04:00
9c8cdede44
file_sys, loader: add support for reading TMDs to determine app paths
2017-10-01 10:54:02 -06:00
6d3b6e0041
nso: Refactor and allocate .bss section.
2017-09-30 14:33:58 -04:00
0e04a4ffd6
loader: Add support for loading an NSO.
2017-09-30 14:32:53 -04:00
d13377a2a9
elf: Check if machine is ARM.
2017-09-30 14:28:53 -04:00
11920a6bd1
Loaders: Don't automatically set the current process every time we load an application.
...
The loaders will now just create a Kernel::Process, construct it and return it to the caller, which is responsible for setting it as the current process and configuring the global page table.
2017-09-26 18:17:47 -05:00
f2b635a73d
HLE/Archives: Allow multiple loaded applications to access their SelfNCCH archive independently.
...
The loaders now register each loaded ROM with the SelfNCCH factory, which keeps the data around for the duration of the emulation session.
When opening the SelfNCCH archive, the factory queries the current program's programid and uses that as a key to the map that contains the NCCHData structure (RomFS, Icon, Banner, etc).
3dsx files do not have a programid and will use a default of 0 for this value, thus, only 1 3dsx file with RomFS is loadable at the same time.
2017-09-25 09:45:02 -05:00
75f023a48b
Merge pull request #2952 from MerryMage/page-tables
...
Switchable Page Tables
2017-09-25 08:29:32 +02:00
042b389b57
Loader/NCCH: Add support for loading application updates ( #2927 )
...
* loader/ncch: split NCCH parsing into its own file
* loader/ncch: add support for loading update NCCHs from the SD card
* loader/ncch: fix formatting
* file_sys/ncch_container: Return a value for OpenFile
* loader/ncch: cleanup, always instantiate overlay_ncch to base_ncch
* file_sys/ncch_container: better encryption checks, allow non-app NCCHs to load properly and for the existence of NCCH structures to be checked
* file_sys/ncch_container: pass filepath as a const reference
2017-09-25 08:17:38 +02:00
6b8ad273fc
memory: Add GetCurrentPageTable/SetCurrentPageTable
...
Don't expose Memory::current_page_table as a global.
2017-09-24 22:42:42 +01:00
36100ec791
Kernel/Memory: Give each Process its own page table.
...
The loader is in charge of setting the newly created process's page table as the main one during the loading process.
2017-09-10 15:13:41 -05:00
95fd4a5e9d
Added missing parts in libnetwork ( #2838 )
...
* Network: Set and send the game information over enet
Added Callbacks for RoomMember and GetMemberList to Room in preparation for web_services.
2017-08-19 11:14:33 -06:00
e5f2839605
loader: Expose program title.
2017-08-03 20:10:37 -04:00
b2bfbf5120
telemetry: Log performance, configuration, and system data.
2017-07-17 21:32:28 -04:00
e0f8f75f43
Addressed Bunnei's review comments, and made some other tweaks:
...
- Deleted GetStatus() because it wasn't used anywhere outside of Core::System.
- Fixed design flaw where the message bar status could be set despite the game being stopped.
2017-06-02 18:40:39 -04:00
b817071212
Created a whitelist of system archives to prevent false positives creating dialogs.
2017-06-02 18:28:14 -04:00
cee9b78a15
Made some changes from review comments:
...
- Made LoadKernelSystemMode return a pair consisting of a system mode and a result code (Could use review).
- Deleted ErrorOpenGL error code in favor of just having ErrorVideoCore.
- Made dialog messages more clear.
- Compared archive ID in fs_user.cpp to ArchiveIdCode::NCCH as opposed to hex magic.
- Cleaned up some other stuff.
2017-06-02 18:28:14 -04:00
1b9c3436ab
Fixed encrypted ROM error messages.
2017-06-02 18:25:32 -04:00
68100e88e0
telemetry: Log a few simple data fields throughout core.
2017-05-24 19:16:23 -04:00
88fddcbce4
Remove ability to load symbol maps
...
This was now mostly unused except by thread creation, which used a
symbol of the entrypoint, if available, to name the thread.
2017-05-07 15:33:07 -07:00
6b607c4b72
loader/ncch: less verbose log for loading game list. only log program ID when booting
2017-03-08 17:37:24 +02:00
d3f36956e1
loader: lower file name logging level
2017-03-08 17:25:09 +02:00
dc1927a9d1
Doxygen: Amend minor issues ( #2593 )
...
Corrects a few issues with regards to Doxygen documentation, for example:
- Incorrect parameter referencing.
- Missing @param tags.
- Typos in @param tags.
and a few minor other issues.
2017-02-26 17:58:51 -08:00
05a989965a
loader: use self NCCH archive
2017-02-13 13:57:38 +02:00
c1d05a2df5
loader: Add support for 3DSX special relocation types, fixes citra-emu/citra#2449
...
As per devkitPro/3dstools@47bea18
2017-01-19 01:34:58 +13:00
1df720ed08
Fix some warnings ( #2399 )
2017-01-04 13:48:29 -03:00
7b3737d9bd
Merge pull request #2240 from wwylele/auto-region
...
Config: auto-select region and language
2016-12-29 22:09:01 -05:00
fdcff791c3
loader: Remove duplicate docstrings.
2016-12-21 23:27:50 -05:00
af97174940
loader: Implement ReadProgramId
2016-12-15 18:42:38 +00:00
a88ec032cd
Config: auto-select region and language
2016-12-07 20:52:42 +02:00
7adac27868
Kernel/Loader: Grab the system mode from the NCCH ExHeader.
...
3dsx and elf files default to system mode 2 (96MB allocated to the application).
This allows Home Menu to boot without modifications.
Closes #1849
2016-11-27 18:03:48 -05:00
d00d0d61e0
Kernel/Loader: Grab the system mode from the NCCH ExHeader.
...
3dsx and elf files default to system mode 2 (96MB allocated to the application).
This allows Home Menu to boot without modifications.
Closes #1849
2016-11-19 20:40:04 -05:00
07fdcf150d
Fix typos
2016-10-20 12:26:59 -02:00
fa5d9d8266
Use negative priorities to avoid special-casing the self-include
2016-09-21 00:15:56 -07:00
1138ec0d49
Remove empty newlines in #include blocks.
...
This makes clang-format useful on those.
Also add a bunch of forgotten transitive includes, which otherwise
prevented compilation.
2016-09-21 11:15:47 +09:00
1e4a5da9f4
Manually tweak source formatting and then re-run clang-format
2016-09-18 21:14:25 -07:00
628ed4376a
Sources: Run clang-format on everything.
2016-09-18 09:38:01 +09:00
3272e30eec
Loader: Split SMDH into its own header and import helpers from QGameList
...
Also rewrite Qt wrappers to use those.
2016-05-21 20:15:42 +01:00
e52461f648
CitraQt: Simplify the game list loader code
2016-05-21 17:09:59 +01:00
85a4eea460
Loader: Add a GetFileType method to get the type of a loaded file
2016-05-21 17:09:59 +01:00
b0095b9584
Loader, Frontends: Refactor loader creation and game loading
...
This allows frontends to keep a single loader and use it multiple times
e.g. for code loading and SMDH parsing.
2016-05-21 17:09:56 +01:00
fe04d0f1cc
Merge pull request #1766 from Subv/log_cpu
...
Kernel/Threading: Warn when a thread can be scheduled in the Syscore (Core 1)
2016-05-08 15:03:08 -04:00
17e9bc5392
fixup simple type conversions where possible
2016-05-07 11:41:55 -04:00
bfee7941e3
Kernel/Threading: Warn when a thread can be scheduled in the Syscore (Core 1).
...
We do not currently implement any cores other than the AppCore (Core 0).
2016-05-07 10:23:03 -05:00
d999f3d0de
fix:return proper error
2016-05-06 21:42:13 +03:00
a23e3f1cd5
add icon & title to game list
2016-05-04 13:02:49 +03:00
44a7dad1e4
ncch: Use correct format specifier (for long long uint)
2016-04-23 11:54:02 +08:00
0e86c22c25
core: Clean out some unnecessary header includes
2016-04-16 00:08:49 -04:00
5ce844dff6
ncch:only decompress .code section
2016-04-14 18:33:42 +03:00
3cf5e4d51c
Merge pull request #1643 from MerryMage/make_unique
...
Common: Remove Common::make_unique, use std::make_unique
2016-04-05 20:10:11 -04:00
9f9c987924
Common: Remove Common::make_unique, use std::make_unique
2016-04-05 13:31:17 +01:00
327d85b039
loader: Make MakeMagic constexpr
2016-03-21 03:28:22 -04:00
ceed7d1030
Merge pull request #1344 from LittleWhite-tb/error-output
...
Output errors in GUI
2016-03-08 23:12:04 -05:00
59fe02348a
Improve error report from Init() functions
...
Add error popup when citra initialization failed
2016-03-08 22:05:25 +01:00
990a3e6038
Loader/NCCH: Log the program ID during loading
...
This is useful for all sorts of things, but mainly to identify save
folders more easily.
2016-03-04 23:53:10 -08:00
c4c48d4ab3
Display errors in GUI when loading ROM failed
2016-03-03 22:52:29 +01:00
f290c57dee
elf: Don't cast away const
2016-01-25 02:36:57 -05:00
7de1f406b8
Merge pull request #1199 from Gareth422/encryption-check
...
Loader: Implement NCCH encryption check
2015-10-20 10:17:31 -04:00
780fd6247f
Loader: Change NCCH header types to be explicitly little-endian
2015-10-10 22:35:22 -04:00
1874d33c0b
Loader: Implement encryption check
2015-10-10 22:34:17 -04:00
b0c7762520
CitraQt, SkyEye, Loader, VideoCore: Remove newlines in LOG_* calls.
...
The LOG_* function itself already appends one.
2015-10-09 22:14:56 +01:00
bc1663cbb8
Merge pull request #1095 from archshift/game-list
...
Initial implementation of a game list
2015-10-01 23:35:19 -04:00
976a199623
Expose loader helper functions for identifying files.
2015-09-30 21:04:47 -07:00
aad98addf2
Implement 3dsx RomFS
2015-09-21 13:03:18 -04:00
54fa043c92
General: Fix up doxygen comments
2015-09-10 11:20:21 -04:00
ef432342ce
Properly indicate that CIA support is not implemented yet
...
Make `Loader::LoadFile` return an `ErrorNotImplemented` if you call
it on a CIA file.
2015-08-15 16:05:38 -04:00
b57680c39f
Give CIA file type a name
...
Make `GetFileTypeString` return ‘CIA’ for CIA (CTR Importable
Archive) files.
2015-08-15 15:45:27 -04:00
43d799fd9d
loader: Remove unnecessary else usages
2015-07-25 18:10:13 -04:00
972dccc3f6
Core : Change variable type
...
and fix various warnings
2015-07-19 04:12:39 -07:00
62c2a262b2
Loader: Fix variable type and remove unused variable
2015-07-13 21:10:13 -03:00
2d7299a86f
Loader: Remove unnecessary pointer indirection to IOFile
2015-07-13 20:00:56 -03:00
c385b7767d
FS: Stream RomFS from file instead of loading all of it to memory
2015-07-13 19:57:12 -03:00
5c5cf2f8e0
Core: Properly configure address space when loading a binary
...
The code now properly configures the process image to match the loaded
binary segments (code, rodata, data) instead of just blindly allocating
a large chunk of dummy memory.
2015-07-11 23:54:42 -03:00
34f5f77507
Loader: Clean up 3dsx loader a bit, fixing a potential buffer overrun
2015-07-11 23:49:52 -03:00
fdbf410bd7
Loader: Make 3dsx loader logs a bit less confusing
2015-07-11 23:49:52 -03:00
867c28ae03
Merge pull request #876 from linkmauve/include-cleanups
...
Cleanup includes, mostly in common
2015-07-10 16:36:12 -07:00
Lioncash
Zach Hilman
bunnei
Subv
Zach Hilman
Hedges
James Rowe
N00byKing
N00byKing
shinyquagsire23
David Marcec
Rozlette
gdkchan
MerryMage
Thog
B3n30
TheKoopaKingdom
Yuri Kunde Schlesner
wwylele
Thomas Farr
Jonathan Hao
Ricardo de Almeida Gonzaga
Emmanuel Gil Peyrot
Alexander Laties
Sam Spilsbury
LittleWhite
Gareth Poole
archshift
Cruel
Benjamin Barenblat
zawata
condut