From 963f9981ce9846a4ed97f6b12c49d9b61db6fab9 Mon Sep 17 00:00:00 2001 From: xbzk Date: Mon, 23 Feb 2026 06:40:42 +0100 Subject: [PATCH] [chore] Resolve more "warning C4127: conditional expression is constant" while building under MSVC (#3595) NOISY warning on NINJA MSVC build log. Complement for PR 3567. Now in another place. D:\dev\eden\src\dynarmic\src\dynarmic\backend\x64\emit_x64_vector_floating_point.cpp(207): warning C4127: conditional expression is constant D:\dev\eden\src\dynarmic\src\dynarmic\backend\x64\emit_x64_vector_floating_point.cpp(207): note: consider using 'if constexpr' statement instead Signed-off-by: xbzk Co-authored-by: DraVee Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3595 Reviewed-by: Lizzie Reviewed-by: DraVee Co-authored-by: xbzk Co-committed-by: xbzk --- src/dynarmic/src/dynarmic/common/assert.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dynarmic/src/dynarmic/common/assert.h b/src/dynarmic/src/dynarmic/common/assert.h index adface269a..a79d865974 100644 --- a/src/dynarmic/src/dynarmic/common/assert.h +++ b/src/dynarmic/src/dynarmic/common/assert.h @@ -1,4 +1,4 @@ -// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project +// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project // SPDX-License-Identifier: GPL-3.0-or-later // SPDX-FileCopyrightText: 2013 Dolphin Emulator Project // SPDX-FileCopyrightText: 2014 Citra Emulator Project @@ -9,7 +9,7 @@ // TODO: Use source_info? [[noreturn]] void assert_terminate_impl(const char* s); #ifndef ASSERT -# define ASSERT(expr) do if(!(expr)) [[unlikely]] assert_terminate_impl(__FILE__ ": " #expr); while(0) +# define ASSERT(expr) do { auto&& condition = !(expr); if(condition) [[unlikely]] assert_terminate_impl(__FILE__ ": " #expr); } while(0) #endif #ifndef UNREACHABLE # ifdef _MSC_VER